Conversation
dartasen
left a comment
There was a problem hiding this comment.
Shouldn't this be separate PR's ?
NitroxModel/DataStructures/GameLogic/Entities/Metadata/KeypadMetadata.cs
Show resolved
Hide resolved
| public static IEnumerator WaitForWorldLoad() | ||
| public static IEnumerator WaitForWorldLoad(WaitForSeconds initialWait = null) | ||
| { | ||
| Entities entities = NitroxServiceLocator.LocateService<Entities>(); |
There was a problem hiding this comment.
You should be using dependency injection, this will generate a warning from our analyzers
There was a problem hiding this comment.
It won't work in this static context
There was a problem hiding this comment.
Terrain is already being required inside Mutiplayer mb, so static can be removed
| public static void WaitForEntities() | ||
| { | ||
| // In case the player is spawned in the air, we need to hold them up while all the entities load around them | ||
| if (Player.main && !Player.main.IsUnderwater() && !Player.main.groundMotor.grounded) |
There was a problem hiding this comment.
Note to fix: this should not trigger when inside a subroot/escape pod
|
// KeypadMetadata.cs } // Terrain.cs } Make sure to replace the placeholder logic in IsInsideSubrootOrEscapePod with the actual implementation that checks the player's position relative to the subroot or escape pod. |
I might want to add a things or two before release which I'll put in here