fix(migration): add internet access role for OIDC enabled jobs #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilhem Barthés <[email protected]>
guilhem-barthes
force-pushed
the
fix/jobsmigration-fails
branch
from
d4d917e to
fbbf7dd
Compare
Kelvin-M
approved these changes
May 26, 2025
Signed-off-by: Guilhem Barthés <[email protected]>
Signed-off-by: Guilhem Barthés <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes RP-1688
Other option considered was to refactor the
sync_userto accept another boolean to deactivate user deletion, but this would also require an app release. Seeing the current status of development, an option requiring the minimum level of action has been chosenHow has this been tested?
Checklist