Skip to content

issue-714 Fix issue with workflow being stuck in running state #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JackBuchanan wants to merge 1 commit into
base: hotfix
Choose a base branch
from
Open

issue-714 Fix issue with workflow being stuck in running state #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions public/legacy/modules/AOW_Actions/actions/actionComputeField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public function run_action(SugarBean $bean, $params = array(), $in_save = false)
$bean->save($check_notify);

return true;
} catch (Exception $e) {
} catch (Throwable $e) {
if (isset($GLOBALS['log'])) {
$GLOBALS['log']->fatal("Calculated Field Exception: " . $e->getMessage());
}
Expand Down Expand Up @@ -367,7 +367,7 @@ public function edit_display($line, SugarBean $bean = null, $params = array())
</thead>
<tbody>
</tbody>
</table>
</table>
<select class='parameterSelect' id='parameterSelect$line'>
$moduleFieldsDropDown
</select>
Expand Down Expand Up @@ -409,7 +409,7 @@ public function edit_display($line, SugarBean $bean = null, $params = array())
</thead>
<tbody>
</tbody>
</table>
</table>
$relationOptions
<select class='relationParameterTypeSelect' id='relationParameterTypeSelect$line'>
<option value='raw'>" .
Expand Down Expand Up @@ -443,7 +443,7 @@ public function edit_display($line, SugarBean $bean = null, $params = array())
</thead>
<tbody>
</tbody>
</table>
</table>
<select>
$moduleFieldsDropDown
</select>
Expand All @@ -465,32 +465,32 @@ public function edit_display($line, SugarBean $bean = null, $params = array())
$html .= "
<script id ='aow_script$line' type='text/javascript'>
computers[$line] = new FieldComputer($line, '$containerName', $parameters, $parameterTypes, $formulas, $formulaContents, $relationParameters, $relationParameterFields, $relationParameterTypes);

function onRelationParameterSelectChange$line() {
$('#$containerName').find('.relationParameterFieldSelect').hide();
$('#$containerName').find('select.relationParameterFieldSelect[relation=\"' + $(this).val() + '\"]').show();
}
$('#relationParameterSelect$line').change(onRelationParameterSelectChange$line);

$('#relationParameterSelect$line').change(onRelationParameterSelectChange$line);
$('#relationParameterSelect$line').change();

function onFieldChange$line(dropdown, valueDropdown) {
var value = $(dropdown).find('option:selected').attr('dataType');
var value = $(dropdown).find('option:selected').attr('dataType');
if (value == 'enum' || value == 'multienum' || value == 'dynamicenum') {
$(valueDropdown).show();
} else {
$(valueDropdown).hide();
}
}

$('#$containerName .computeFieldParametersContainer').find('.parameterSelect').change(function () {
onFieldChange$line(this, $('#$containerName .computeFieldParametersContainer').find('.parameterTypeSelect'));
});

$('#$containerName .computeFieldRelationParametersContainer').find('.relationParameterFieldSelect').change(function () {
onFieldChange$line(this, $('#$containerName .computeFieldRelationParametersContainer').find('.relationParameterTypeSelect'));
});

$('#$containerName .computeFieldParametersContainer').find('.parameterSelect').change();
$('#$containerName .computeFieldRelationParametersContainer').find('.relationParameterFieldSelect:visible').change();
</script>
Expand Down