add omitempty tag to ViewFilter in ViewFilterDefinition #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: Add omitempty tag to ViewFilter
Problem: Creating Sumo Logic roles with selection_type = "Deny" fails
with "view_filter_should_be_null" error when view_filter is not specified.
Cause: Unset view_filter fields were serialized as empty strings ("")
instead of being omitted from JSON, causing backend validation to fail.
Fix: Added omitempty JSON tag to ViewFilterDefinition.ViewFilter
field. Empty values are now omitted from the JSON payload.
Result: Users can now create and update Deny roles without validation errors.
Check list
CHANGELOG.mdCONTRIBUTING.mdfor anything forgotten