Fix collector creation error by including all fields in initial create request #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where hosted collector creation would show an error to the user despite the collector being successfully created.
Problem
The
resourceSumologicCollectorCreatefunction was using a two-step process:nameandcollectorType)resourceSumologicCollectorUpdateto set remaining fieldsIf step 2 failed (due to ETag issues, timing problems, or API errors), the function would return an error even though the collector was already created in step 1. This led to:
Solution
Changed
resourceSumologicCollectorCreateto include all fields in the initialCreateCollectorAPI call:namedescriptioncategorytimezone(with default "Etc/UTC")fieldsThe function now calls
resourceSumologicCollectorReaddirectly instead of going throughresourceSumologicCollectorUpdate.Backward Compatibility
This change is fully backward compatible:
omitemptyJSON tags, so empty values aren't sent to the APICheck list
CHANGELOG.mdCONTRIBUTING.mdfor anything forgotten