Issue #SB-24793: Response Exhaust V2 job to support assessment blob data#451
Open
utk14 wants to merge 5 commits intoSunbird-Ed:release-4.4.0from
Open
Issue #SB-24793: Response Exhaust V2 job to support assessment blob data#451utk14 wants to merge 5 commits intoSunbird-Ed:release-4.4.0from
utk14 wants to merge 5 commits intoSunbird-Ed:release-4.4.0from
Conversation
manjudr
requested changes
Aug 5, 2021
...-products/src/main/scala/org/sunbird/analytics/exhaust/collection/ResponseExhaustJobV2.scala
Outdated
Show resolved
Hide resolved
...-products/src/main/scala/org/sunbird/analytics/exhaust/collection/ResponseExhaustJobV2.scala
Outdated
Show resolved
Hide resolved
...-products/src/main/scala/org/sunbird/analytics/exhaust/collection/ResponseExhaustJobV2.scala
Show resolved
Hide resolved
...-products/src/main/scala/org/sunbird/analytics/exhaust/collection/ResponseExhaustJobV2.scala
Outdated
Show resolved
Hide resolved
| val azureFetcherConfig = config.modelParams.get("assessmentFetcherConfig").asInstanceOf[Map[String, AnyRef]] | ||
|
|
||
| val store = azureFetcherConfig("store") | ||
| val format:String = azureFetcherConfig.getOrElse("format", "csv").asInstanceOf[String] |
Collaborator
There was a problem hiding this comment.
If the multiple archived data has created and data has been duplicated for a batch then how are we handling it here? If not could you please handle this scenario?
|
SonarCloud Quality Gate failed. |
SanthoshVasabhaktula
requested changes
Oct 25, 2021
Comment on lines
+15
to
+24
| val url = store match { | ||
| case "local" => | ||
| filePath + s"${batchid}-*.${format}" | ||
| // $COVERAGE-OFF$ for azure testing | ||
| case "s3" | "azure" => | ||
| val key = AppConf.getConfig("azure_storage_key") | ||
| val file = s"${filePath}${batchid}-*.${format}" | ||
| s"wasb://$bucket@$key.blob.core.windows.net/$file." | ||
| // $COVERAGE-ON$ | ||
| } |
Collaborator
There was a problem hiding this comment.
Move to a commonutil method
Comment on lines
+60
to
+71
| val assessAggregateData = loadData(assessmentAggDBSettings, cassandraFormat, new StructType()) | ||
|
|
||
| val joinedDF = try { | ||
| val assessBlobData = getAssessmentBlobDF(batchid, config) | ||
|
|
||
| val joinDF = assessAggregateData.join(assessBlobData, Seq("batch_id", "course_id", "user_id"), "left") | ||
| .select(assessAggregateData.col("*")) | ||
| joinDF | ||
| } catch { | ||
| case e => JobLogger.log("Blob does not contain any file for batchid: " + batchid) | ||
| assessAggregateData | ||
| } |
Collaborator
There was a problem hiding this comment.
Are we still creating one single CSV file of few GBs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://project-sunbird.atlassian.net/browse/SB-24793
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: