changes in content publish job and question set job for interactive v… - #437
Open
parekhsaloni25 wants to merge 8 commits into
Open
changes in content publish job and question set job for interactive v…#437parekhsaloni25 wants to merge 8 commits into
parekhsaloni25 wants to merge 8 commits into
Conversation
parekhsaloni25
force-pushed
the
release-4.7.0
branch
4 times, most recently
from
January 17, 2022 10:21
82a705c to
1677e4c
Compare
AmiableAnil
reviewed
Jan 19, 2022
AmiableAnil
reviewed
Jan 19, 2022
AmiableAnil
reviewed
Jan 19, 2022
AmiableAnil
reviewed
Jan 19, 2022
AmiableAnil
reviewed
Jan 19, 2022
AmiableAnil
reviewed
Jan 19, 2022
AmiableAnil
reviewed
Jan 19, 2022
parekhsaloni25
force-pushed
the
release-4.7.0
branch
from
February 7, 2022 07:13
fd0e642 to
02559a0
Compare
parekhsaloni25
force-pushed
the
release-4.7.0
branch
from
February 7, 2022 09:29
f1f3cb0 to
413d192
Compare
parekhsaloni25
force-pushed
the
release-4.7.0
branch
from
February 10, 2022 03:45
caef449 to
bae5092
Compare
parekhsaloni25
force-pushed
the
release-4.7.0
branch
from
February 10, 2022 04:12
8c91b41 to
41216f0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
AmiableAnil
reviewed
Feb 10, 2022
| val publishChainMetadata: Map[String, AnyRef] = JSONUtil.deserialize[Map[String, AnyRef]](data.publishChainMetadata) | ||
| val eData: Map[String, AnyRef] = publishChainMetadata.getOrElse("edata", Map[String, AnyRef]()).asInstanceOf[Map[String, AnyRef]] | ||
| val publishChain: List[Map[String, AnyRef]] = eData.getOrElse("publishchain", List[Map[String, AnyRef]]()).asInstanceOf[List[Map[String, AnyRef]]] | ||
| new ObjectData(obj.identifier, obj.metadata ++ Map("publishchain" -> publishChain), obj.extData, obj.hierarchy) |
Contributor
There was a problem hiding this comment.
You can read the publishChain as data.publishChain
Author
There was a problem hiding this comment.
data.publishChain is different. I want to read the object from publishChainMetadata string. so first string is converted to object and then publishChain is read from it
AmiableAnil
approved these changes
Feb 16, 2022
|
Hi @AmiableAnil regarding your question about spine ecar vs full ecar, in this case we are generating only the full ecar which has all the question sets. The spine ecar won't work in this case, since we need to ensure all the question sets are pre-downloaded before the video can play. We will update the code to 4.8 and let you know, so you can go ahead and merge. |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in content publish job and question set publish job to read publish chain event.
Publish chain event will be posted to content publish job. Content publish job will validate event and depending on object type post it to respective jobs.