Issue #SBCOSS-432 fix : Added GCP support#1100
Merged
pallakartheekreddy merged 1 commit intoSunbird-Knowlg:release-6.1.0from May 12, 2025
Merged
Issue #SBCOSS-432 fix : Added GCP support#1100pallakartheekreddy merged 1 commit intoSunbird-Knowlg:release-6.1.0from
pallakartheekreddy merged 1 commit intoSunbird-Knowlg:release-6.1.0from
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GCP cloud storage by updating dependency versions, modifying the signed URL retrieval logic, and adding new GCP credential configurations.
- Updated dependency versions in pom.xml files to support newer GCP libraries
- Added a branch for GCP in the signed URL function in StorageService.scala to pass additional GCP credentials
- Introduced new configuration keys in application.conf for GCP credentials
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| platform-modules/url-manager/pom.xml | Updated YouTube API dependency version and removed guava-jdk5 exclusion to align with GCP support |
| platform-modules/mimetype-manager/src/main/scala/org/sunbird/cloudstore/StorageService.scala | Added conditional logic to pass GCP-specific parameters for generating signed URLs |
| platform-modules/mimetype-manager/pom.xml | Introduced explicit dependencies for guava and google-api-client with updated versions |
| content-api/content-service/conf/application.conf | Added new configuration keys for GCP credentials |
pallakartheekreddy
approved these changes
May 12, 2025
ee6afc2
into
Sunbird-Knowlg:release-6.1.0
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: