Skip to content

Issue #SBCOSS-432 fix : Added GCP support#1100

Merged
pallakartheekreddy merged 1 commit intoSunbird-Knowlg:release-6.1.0from
aimansharief:gcp-support-6.1.0
May 12, 2025
Merged

Issue #SBCOSS-432 fix : Added GCP support#1100
pallakartheekreddy merged 1 commit intoSunbird-Knowlg:release-6.1.0from
aimansharief:gcp-support-6.1.0

Conversation

@aimansharief
Copy link
Copy Markdown
Collaborator

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Test A
  • Ran Test B

Test Configuration:

  • Software versions: Java 11, scala-2.12, play-2.7.2
  • Hardware versions: 2 CPU/ 4GB RAM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for GCP cloud storage by updating dependency versions, modifying the signed URL retrieval logic, and adding new GCP credential configurations.

  • Updated dependency versions in pom.xml files to support newer GCP libraries
  • Added a branch for GCP in the signed URL function in StorageService.scala to pass additional GCP credentials
  • Introduced new configuration keys in application.conf for GCP credentials

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
platform-modules/url-manager/pom.xml Updated YouTube API dependency version and removed guava-jdk5 exclusion to align with GCP support
platform-modules/mimetype-manager/src/main/scala/org/sunbird/cloudstore/StorageService.scala Added conditional logic to pass GCP-specific parameters for generating signed URLs
platform-modules/mimetype-manager/pom.xml Introduced explicit dependencies for guava and google-api-client with updated versions
content-api/content-service/conf/application.conf Added new configuration keys for GCP credentials

@pallakartheekreddy pallakartheekreddy merged commit ee6afc2 into Sunbird-Knowlg:release-6.1.0 May 12, 2025
0 of 2 checks passed
@pallakartheekreddy pallakartheekreddy deleted the gcp-support-6.1.0 branch May 12, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants