Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces GitHub Actions workflows for the taxonomy, search, and content services while also updating the README with the necessary workflow prerequisites.
- Added GitHub Actions workflows for building, packaging, and pushing Docker images for three services.
- Updated the README.md to document the secrets configuration and environment variable prerequisites for these workflows.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Added prerequisites documentation for GitHub Actions. |
| .github/workflows/taxonomy-service.yml | New workflow to build and push the taxonomy service image. |
| .github/workflows/search-service.yml | New workflow to build and push the search service image. |
| .github/workflows/content-service.yml | New workflow to build and push the content service image. |
Comments suppressed due to low confidence (1)
README.md:223
- [nitpick] The secret name REGISTRY_NAME is used under multiple registry sections which may be confusing; consider distinguishing them (e.g., REGISTRY_NAME_DOCKERHUB) or adding clarifying notes to avoid ambiguity.
- `REGISTRY_NAME`: DockerHub registry name (e.g., `docker.io`).
| # Step 5: Package the project | ||
| - name: Package Taxonomy API Service | ||
| run: | | ||
| cd taxonomy-api |
There was a problem hiding this comment.
[nitpick] The directory name 'taxonomy-api' differs from the packaging target 'taxonomy-service'; consider aligning these names to reduce confusion.
| cd taxonomy-api | |
| cd taxonomy-service |
| # Step 5: Package the project | ||
| - name: Package Search API Service | ||
| run: | | ||
| cd search-api |
There was a problem hiding this comment.
[nitpick] The directory name 'search-api' differs from the packaging target 'search-service'; consider aligning these names for clarity.
| cd search-api | |
| cd search-service |
| # Step 4: Package the project | ||
| - name: Package Content Service | ||
| run: | | ||
| cd content-api |
There was a problem hiding this comment.
[nitpick] The directory name 'content-api' differs from the packaging target 'content-service'; aligning these names may improve maintainability.
| cd content-api | |
| cd content-service |
This PR contains Github action workflow for content, taxonomy and search service. Also updated the Readme with the details related to the workflows.