Issue #KN-000 fix: gcp schema fix#1102
Merged
pallakartheekreddy merged 2 commits intoSunbird-Knowlg:release-6.1.0from Jun 25, 2025
Merged
Issue #KN-000 fix: gcp schema fix#1102pallakartheekreddy merged 2 commits intoSunbird-Knowlg:release-6.1.0from
pallakartheekreddy merged 2 commits intoSunbird-Knowlg:release-6.1.0from
Conversation
Issue #KN-000 fix: gcp schema fix
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with GCP schema processing by updating the way the JSON schema is read from the provided InputStream.
- The method now reads the full stream into a byte array and wraps it in a ByteArrayInputStream before processing.
- The method signature has been updated to declare that it throws Exception.
| */ | ||
| protected JsonSchema readSchema(InputStream stream) { | ||
| try (JsonSchemaReader reader = schemaReaderFactory.createSchemaReader(stream)) { | ||
| protected JsonSchema readSchema(InputStream stream) throws Exception{ |
There was a problem hiding this comment.
Avoid throwing a generic 'Exception' in the method signature; consider specifying a more precise exception type that relates directly to JSON schema processing.
| protected JsonSchema readSchema(InputStream stream) { | ||
| try (JsonSchemaReader reader = schemaReaderFactory.createSchemaReader(stream)) { | ||
| protected JsonSchema readSchema(InputStream stream) throws Exception{ | ||
| byte[] bytes = stream.readAllBytes(); |
There was a problem hiding this comment.
Reading the entire InputStream into a byte array may impact performance and memory usage if the schema is large; consider using a buffered approach if large schemas are expected.
91f3562
into
Sunbird-Knowlg:release-6.1.0
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: