Issue #SBCOSS-450 feat : Github Actions for knowledge platform#1103
Conversation
GitHub actions
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces GitHub Actions workflows and documentation updates to support automated builds and pushes for various services in the knowledge platform.
- Adds documentation outlining GitHub Actions workflow prerequisites in the README.md
- Implements three new workflows to build, package, and push Docker images for the Taxonomy, Search, and Content services
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Adds a prerequisites section for configuring secrets and environment variables |
| .github/workflows/taxonomy-service.yml | Implements a workflow to build, package, and push the Taxonomy API Service image |
| .github/workflows/search-service.yml | Implements a workflow to build, package, and push the Search API Service image |
| .github/workflows/content-service.yml | Implements a workflow to build, package, and push the Content Service image |
| curl http://localhost:9000/health | ||
| ``` | ||
|
|
||
| ### GitHub Actions Workflow Prerequisites |
There was a problem hiding this comment.
Consider clarifying what happens if 'REGISTRY_PROVIDER' is not explicitly set, so users have clear guidance on default behavior.
| -DCLOUD_STORE_VERSION=${{ vars.CLOUD_STORE_VERSION }} | ||
|
|
||
| # Step 6: Set up Login to Docker registry | ||
| - name: Determine registry and login |
There was a problem hiding this comment.
The registry login logic is similar across multiple workflows; consider abstracting this step into a reusable composite action or script to reduce duplication.
.github/workflows/search-service.yml
Outdated
| -DCLOUD_STORE_VERSION=${{ vars.CLOUD_STORE_VERSION }} | ||
|
|
||
| # Step 6: Set up Login to Docker registry | ||
| - name: Determine registry and login |
There was a problem hiding this comment.
The registry login logic here duplicates that in other workflows; a reusable composite action would enhance maintainability.
| -DCLOUD_STORE_VERSION=${{ vars.CLOUD_STORE_VERSION }} | ||
|
|
||
| # Step 5: Set up Login to Docker registry | ||
| - name: Determine registry and login |
There was a problem hiding this comment.
As with the other service workflows, consider refactoring the duplicated registry login logic into a single reusable component to simplify future maintenance.
…ded a composite reusable action. Updated Readme.
Updated github actions. Avoiding duplication of docker login step. Ad…
pallakartheekreddy
merged commit 58870da
into
Sunbird-Knowlg:release-8.0.0
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: