Issue #SB-COSS-000 fix: Release-8.0.0 vulnerability fixes#1119
Conversation
fix: vul fixes in knowledge-platform
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses vulnerability fixes for release 8.0.0 by updating various dependencies to their latest secure versions and managing transitive dependency conflicts through exclusions.
- Updates multiple vulnerable dependencies to their latest secure versions (Jackson, Netty, Logback, Commons libraries)
- Implements explicit dependency exclusions to prevent version conflicts and ensure consistent dependency resolution
- Standardizes dependency versions across multiple services for better security and maintainability
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| taxonomy-api/taxonomy-service/pom.xml | Updates Jackson, Netty, Logback, and Snappy dependencies with exclusions |
| search-api/search-service/pom.xml | Similar dependency updates with exclusions for Jackson, Netty, Logback, and Snappy |
| search-api/search-core/pom.xml | Updates Commons BeanUtils, Jackson dependencies with version management |
| platform-modules/url-manager/pom.xml | Updates Google OAuth client dependency with exclusions |
| platform-modules/mimetype-manager/pom.xml | Updates Netty, Commons BeanUtils, and Jackson Core dependencies |
| platform-core/platform-telemetry/pom.xml | Updates Logback dependencies with exclusions |
| platform-core/platform-common/pom.xml | Updates Commons IO and Jackson Core dependencies |
| content-api/content-service/pom.xml | Updates Jackson, Logback, and Netty dependencies with exclusions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <artifactId>netty-codec-http</artifactId> | ||
| <version>4.1.44.Final</version> |
There was a problem hiding this comment.
The netty-codec-http version 4.1.44.Final is outdated and may contain security vulnerabilities. Consider updating to version 4.1.118.Final to match the netty-handler version used in other modules for consistency and security.
| <artifactId>netty-codec-http</artifactId> | |
| <version>4.1.44.Final</version> | |
| <version>4.1.118.Final</version> |
| <artifactId>netty-handler</artifactId> | ||
| <version>4.1.46.Final</version> |
There was a problem hiding this comment.
The netty-handler version 4.1.46.Final is outdated compared to version 4.1.118.Final used in other modules. This inconsistency could introduce security vulnerabilities and compatibility issues. Update to 4.1.118.Final for consistency.
| <artifactId>netty-handler</artifactId> | |
| <version>4.1.46.Final</version> | |
| <version>4.1.118.Final</version> |
| <artifactId>netty-codec</artifactId> | ||
| <version>4.1.68.Final</version> |
There was a problem hiding this comment.
The netty-codec version 4.1.68.Final is newer than the other Netty components but still behind the 4.1.118.Final version used elsewhere. For security and compatibility, all Netty components should use the same version 4.1.118.Final.
| <artifactId>netty-codec</artifactId> | |
| <version>4.1.68.Final</version> | |
| <version>4.1.118.Final</version> |
09d6e64
into
Sunbird-Knowlg:release-8.0.0
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: