#SBCOSS-625: Textbook collection update upon csv update#1121
#SBCOSS-625: Textbook collection update upon csv update#1121pallakartheekreddy merged 11 commits intoSunbird-Knowlg:release-8.0.0from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
Updates collection CSV handling to correctly classify child nodes by their own content type and adds an explicit return type to a validator.
- Check child node contentType instead of parent when building unitChildren and linkedContents
- Add explicit Unit return type to validateCollection method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ction-csv-actors/src/main/scala/org.sunbird/collectioncsv/manager/CollectionCSVManager.scala
Outdated
Show resolved
Hide resolved
...ction-csv-actors/src/main/scala/org.sunbird/collectioncsv/manager/CollectionCSVManager.scala
Outdated
Show resolved
Hide resolved
...ction-csv-actors/src/main/scala/org.sunbird/collectioncsv/manager/CollectionCSVManager.scala
Show resolved
Hide resolved
7abad76
into
Sunbird-Knowlg:release-8.0.0
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: