Refactor/framework actor decompose#1195
Open
pallakartheekreddy wants to merge 3 commits intocloud-store-refactoringfrom
Open
Refactor/framework actor decompose#1195pallakartheekreddy wants to merge 3 commits intocloud-store-refactoringfrom
pallakartheekreddy wants to merge 3 commits intocloud-store-refactoringfrom
Conversation
Phase 3.3/3.4 — FrameworkActor:
- Extract readChannelNode() helper (shared by create() and publish()),
replacing duplicated 8-line channel-request boilerplate with one call.
- Extract fetchFrameworkFromStorage() to separate Cassandra/Redis read logic
out of read(), keeping the handler focused on response assembly.
- Extract persistFrameworkHierarchy() from publish(), encapsulating
SubGraph read + hierarchy compute + Cassandra/Redis save in one helper.
- Replace all .map().flatMap(f=>f) chains with direct .flatMap{} calls.
Phase 3.6 — FrameworkManager.getCompleteMetadata():
- Extract buildFilteredNodeMetadata() covering node-null guard, JSON-property
conversion, key normalisation, and schema-field filtering (lines 76-90).
- Extract sortedOutRelations() for the filter+sortBy relation list (lines 92-95).
- getCompleteMetadata() now delegates to these helpers; recursive calls and
return types are unchanged.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: