fix: Critical and High Vulnerability fixes

[romitshah02]

fixed package version having vulnerabilities

Summary by CodeRabbit

• Security

  • Updated HtmlUnit test dependencies to use a safer, explicitly managed version and exclude a vulnerable transitive artifact.
  • Updated the HTML sanitizer dependency to a newer release.

• Maintenance

  • Updated Jackson, Netty, and Apache Commons Configuration dependencies.
  • Removed the legacy JSON-Lib dependency.
  • Improved dependency consistency across services and modules.

[coderabbitai]

Warning

Review limit reached

@romitshah02, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e35dc126-89f8-45ac-8351-c32f818e0d70

📥 Commits

Reviewing files that changed from the base of the PR and between 33a4071 and 37af7f7.

📒 Files selected for processing (1)

• pom.xml

📝 Walkthrough

Walkthrough

The PR updates managed Jackson, Netty, Commons Configuration, and HTML sanitizer versions, replaces vulnerable transitive HtmlUnit test dependencies with org.htmlunit:htmlunit, and removes the legacy json-lib dependency.

Changes

Dependency and security updates

Layer / File(s)	Summary
Managed dependency versions pom.xml	Updates centrally managed Jackson, Netty, Commons Configuration, and HtmlUnit versions.
Module dependency alignment assessment-api/..., content-api/..., knowlg-service/pom.xml, platform-core/..., search-api/..., taxonomy-api/...	Aligns module-level Jackson, Netty, HTML sanitizer, and CBOR dependencies with the updated versions and removes json-lib.
Secure HtmlUnit test dependencies assessment-api/assessment-service/pom.xml, content-api/content-service/pom.xml, search-api/search-service/pom.xml, taxonomy-api/taxonomy-service/pom.xml	Excludes net.sourceforge.htmlunit:htmlunit and adds the test-scoped org.htmlunit:htmlunit dependency.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

• Sunbird-Knowlg/knowledge-platform#1213: Updates overlapping Maven Netty version properties.

Suggested reviewers: aimansharief, sntiwari1

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is too vague and misses the required summary, issue reference, change type, testing, and checklist sections.	Expand it to follow the template: add summary/context, issue fixed, required dependencies, change type, testing steps, config, and checklist items.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the PR’s main purpose: security vulnerability fixes across package versions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

content-api/hierarchy-manager/pom.xml (1)

92-98: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove redundant hardcoded Netty versions.

Since io.netty:netty-bom is imported in the root pom.xml's <dependencyManagement> block, explicitly defining the version here is redundant and can lead to mismatches in the future. Consider removing the <version> tags to rely purely on central dependency management.

♻️ Proposed refactor

         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-codec</artifactId>
-            <version>4.1.135.Final</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-handler</artifactId>
-            <version>4.1.135.Final</version>
             <scope>test</scope>
         </dependency>  

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@content-api/hierarchy-manager/pom.xml` around lines 92 - 98, Remove the
explicit 4.1.135.Final version tags from the Netty dependencies, including
netty-handler and the adjacent Netty test dependency, so their versions are
resolved through the root pom.xml dependencyManagement netty-bom.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@platform-core/platform-common/pom.xml`:
- Line 91: Update the dependency version for owasp-java-html-sanitizer in the
Maven configuration from the unpublished 20260101.1 pin to the published
20240325.1 release.

In `@search-api/search-core/pom.xml`:
- Line 107: Align the Jackson module versions in pom.xml by updating
jackson-dataformat-cbor to 2.18.9 to match jackson-databind. Prefer the existing
dependency-management approach, such as jackson-bom if available, so all Jackson
artifacts share one version.

---

Nitpick comments:
In `@content-api/hierarchy-manager/pom.xml`:
- Around line 92-98: Remove the explicit 4.1.135.Final version tags from the
Netty dependencies, including netty-handler and the adjacent Netty test
dependency, so their versions are resolved through the root pom.xml
dependencyManagement netty-bom.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e93062d7-af34-41e0-b93c-03a5c5de78d0

📥 Commits

Reviewing files that changed from the base of the PR and between 448714d and 33a4071.

📒 Files selected for processing (12)

• assessment-api/assessment-controllers/pom.xml
• assessment-api/assessment-service/pom.xml
• content-api/content-controllers/pom.xml
• content-api/content-service/pom.xml
• content-api/hierarchy-manager/pom.xml
• knowlg-service/pom.xml
• platform-core/platform-common/pom.xml
• pom.xml
• search-api/search-core/pom.xml
• search-api/search-service/pom.xml
• taxonomy-api/taxonomy-controllers/pom.xml
• taxonomy-api/taxonomy-service/pom.xml

[coderabbitai]

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch the available versions of owasp-java-html-sanitizer from Maven Central
curl -s "https://search.maven.org/solrsearch/select?q=g:com.googlecode.owasp-java-html-sanitizer+AND+a:owasp-java-html-sanitizer&core=gav&rows=10&wt=json" | jq '.response.docs[].v'

Repository: Sunbird-Knowlg/knowledge-platform

Length of output: 301

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the dependency declaration around the pinned version
sed -n '80,100p' platform-core/platform-common/pom.xml

echo
echo "----"
# Find all occurrences of the sanitizer artifact/version in the repo
rg -n "owasp-java-html-sanitizer|20260101\.1" -S .

Repository: Sunbird-Knowlg/knowledge-platform

Length of output: 1227

---

Use a published owasp-java-html-sanitizer version 20260101.1 is not published on Maven Central; the latest available release is 20240325.1. Update this pin to a released version.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@platform-core/platform-common/pom.xml` at line 91, Update the dependency
version for owasp-java-html-sanitizer in the Maven configuration from the
unpublished 20260101.1 pin to the published 20240325.1 release.

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Align Jackson dependency versions.

jackson-databind was updated to 2.18.9, but jackson-dataformat-cbor (at line 96) is still on version 2.18.6. Mixing Jackson module versions can lead to runtime compatibility issues such as NoSuchMethodError. It is highly recommended to use the same version for all Jackson artifacts, ideally managed via jackson-bom.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@search-api/search-core/pom.xml` at line 107, Align the Jackson module
versions in pom.xml by updating jackson-dataformat-cbor to 2.18.9 to match
jackson-databind. Prefer the existing dependency-management approach, such as
jackson-bom if available, so all Jackson artifacts share one version.