#SBCOSS-524: workflow to publish package to npm #10
Merged
pallakartheekreddy merged 2 commits intoSunbird-Knowlg:mainfrom Jul 7, 2025
Merged
#SBCOSS-524: workflow to publish package to npm #10pallakartheekreddy merged 2 commits intoSunbird-Knowlg:mainfrom
pallakartheekreddy merged 2 commits intoSunbird-Knowlg:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds automation for code quality checks on pull requests and a new workflow to publish the package to npm.
- Include
pull_requesttrigger alongsidepushin the existing Code Quality workflow - Introduce
publish.ymlto build and publish the package when tags are pushed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/pull_request.yml | Added pull_request event under the on block |
| .github/workflows/publish.yml | Created workflow to install, build, and publish app |
Comments suppressed due to low confidence (3)
.github/workflows/pull_request.yml:4
- The
onblock currently treats events as list items (with- push:and- pull_request:), which isn’t valid YAML mapping syntax. Switch to direct key mappings underon:
on:
push:
branches: ['**']
pull_request:
branches: ['**']
pull_request:
.github/workflows/publish.yml:6
- [nitpick] Using a wildcard (
'*') for tags will trigger on every tag, including non-release ones. Consider restricting to semantic version patterns likev*.*.*to avoid accidental publishes.
- '*'
.github/workflows/publish.yml:21
- Since
actions/setup-node@v4is already configured withcache: 'npm', the manualactions/cachesteps for restoring and savingnode_modulesare redundant. You can remove them to simplify the workflow.
- name: Restore node_modules cache
pallakartheekreddy
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.