Skip to content

#SBCOSS-524: workflow to publish package to npm #10

Merged
pallakartheekreddy merged 2 commits intoSunbird-Knowlg:mainfrom
Rakshitha-D:workflows
Jul 7, 2025
Merged

#SBCOSS-524: workflow to publish package to npm #10
pallakartheekreddy merged 2 commits intoSunbird-Knowlg:mainfrom
Rakshitha-D:workflows

Conversation

@Rakshitha-D
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds automation for code quality checks on pull requests and a new workflow to publish the package to npm.

  • Include pull_request trigger alongside push in the existing Code Quality workflow
  • Introduce publish.yml to build and publish the package when tags are pushed

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/pull_request.yml Added pull_request event under the on block
.github/workflows/publish.yml Created workflow to install, build, and publish app
Comments suppressed due to low confidence (3)

.github/workflows/pull_request.yml:4

  • The on block currently treats events as list items (with - push: and - pull_request:), which isn’t valid YAML mapping syntax. Switch to direct key mappings under on:
on:
  push:
    branches: ['**']
  pull_request:
    branches: ['**']
  pull_request:

.github/workflows/publish.yml:6

  • [nitpick] Using a wildcard ('*') for tags will trigger on every tag, including non-release ones. Consider restricting to semantic version patterns like v*.*.* to avoid accidental publishes.
      - '*'

.github/workflows/publish.yml:21

  • Since actions/setup-node@v4 is already configured with cache: 'npm', the manual actions/cache steps for restoring and saving node_modules are redundant. You can remove them to simplify the workflow.
      - name: Restore node_modules cache

@pallakartheekreddy pallakartheekreddy merged commit 8145862 into Sunbird-Knowlg:main Jul 7, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants