Coss 5.2.1 actions by yashashkumar · Pull Request #88 · Sunbird-Knowlg/sunbird-generic-editor

yashashkumar · 2025-07-23T12:12:13Z

No description provided.

…Linting steps also added in the workflow.

Github action to build and push to blob

Copilot

Pull Request Overview

This PR adds GitHub Actions CI/CD workflows and updates the project's ESLint configuration. The changes introduce automated build, test, and deployment processes triggered by pull requests and tag pushes.

Adds GitHub Actions workflows for pull request validation and automated publishing
Updates ESLint from version 5.6.0 to 8.57.1 with additional configuration packages
Migrates ESLint configuration from JSON format to JavaScript module format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
package.json	Updates ESLint version and adds new linting dependencies plus lint script
README.md	Adds comprehensive documentation for GitHub Actions workflows
.github/workflows/pull-request.yml	Implements PR validation workflow with build, test, and lint checks
.github/workflows/publish.yml	Implements automated publishing workflow for multiple cloud providers
.eslintrc.js	Creates new JavaScript-based ESLint configuration with warning-only plugin
.eslintrc	Removes old JSON-based ESLint configuration file

Copilot · 2025-07-23T12:24:09Z

+
+      - name: Clone plugins (from fork)
+        run: |
+          git clone --branch ${{ env.CONTENT_PLUGIN_VERSION }} https://github.com/vinodbhorge/sunbird-content-plugins.git plugins


The workflow clones from a personal fork (vinodbhorge/sunbird-content-plugins) instead of the official repository. This introduces a security risk as the personal fork could contain malicious code.

Suggested change

git clone --branch ${{ env.CONTENT_PLUGIN_VERSION }} https://github.com/vinodbhorge/sunbird-content-plugins.git plugins

git clone --branch ${{ env.CONTENT_PLUGIN_VERSION }} https://github.com/Sunbird-Ed/sunbird-content-plugins.git plugins

Copilot · 2025-07-23T12:24:09Z

+
+      - name: Test
+        run: npm run test
+        continue-on-error: true


Tests are allowed to fail without stopping the workflow. This defeats the purpose of running tests in CI/CD and could allow broken code to pass validation.

Suggested change

continue-on-error: true

Copilot · 2025-07-23T12:24:10Z

+        with:
+          path: node_modules
+          key: ${{ runner.os }}-node-${{ hashFiles('package.json') }}
+


The lint job depends on build-test but doesn't install dependencies. The cached node_modules from the build-test job won't be available since jobs run in separate environments.

Suggested change

- name: Install dependencies

run: npm install --legacy-peer-deps

Copilot · 2025-07-23T12:24:10Z

+
+      - name: Clone content plugins


The workflow assumes that every tag pushed to this repository has a corresponding branch with the same name in the sunbird-content-plugins repository, which may not always be true and could cause the workflow to fail.

Suggested change

- name: Clone content plugins

- name: Check if branch exists in sunbird-content-plugins

run: |

if git ls-remote --heads https://github.com/Sunbird-Knowlg/sunbird-content-plugins.git ${{ github.ref_name }} | grep -q ${{ github.ref_name }}; then

echo "Branch ${{ github.ref_name }} exists in sunbird-content-plugins."

echo "true" > branch_exists.txt

else

echo "Branch ${{ github.ref_name }} does not exist in sunbird-content-plugins."

echo "false" > branch_exists.txt

fi

- name: Clone content plugins

if: ${{ steps.check-branch.outputs.branch_exists == 'true' }}

Copilot · 2025-07-23T12:24:10Z

    "eslint-plugin-import": "^2.14.0",
    "eslint-plugin-node": "^7.0.1",
    "eslint-plugin-promise": "^4.0.1",
    "eslint-plugin-standard": "^4.0.0",
+    "eslint-config-standard": "^12.0.0",


Upgrading ESLint from version 5.6.0 to 8.57.1 is a major version jump that may introduce breaking changes. Consider testing thoroughly to ensure existing code still passes linting with the new version.

Suggested change

"eslint-plugin-import": "^2.14.0",

"eslint-plugin-node": "^7.0.1",

"eslint-plugin-promise": "^4.0.1",

"eslint-plugin-standard": "^4.0.0",

"eslint-config-standard": "^12.0.0",

"eslint-plugin-import": "^2.27.5",

"eslint-plugin-node": "^11.1.0",

"eslint-plugin-promise": "^6.1.1",

"eslint-plugin-standard": "^5.0.0",

"eslint-config-standard": "^17.0.0",

Copilot · 2025-07-23T12:24:11Z

+`SONAR_TOKEN`: For SonarQube authentication 
+
+### Repository Variables
+`CONTENT_PLUGIN_VERSION`: Have to specify the branch or tag you want fetch. By default it will take `release-8.0.0`


Grammar error: 'you want fetch' should be 'you want to fetch'.

Suggested change

`CONTENT_PLUGIN_VERSION`: Have to specify the branch or tag you want fetch. By default it will take `release-8.0.0`

`CONTENT_PLUGIN_VERSION`: Have to specify the branch or tag you want to fetch. By default it will take `release-8.0.0`

vinodbhorge and others added 21 commits June 25, 2025 14:31

Added workflow for build, run test cases and sonar analysis on a PR. …

834abbf

…Linting steps also added in the workflow.

Updated the Readme file.

dd57bfc

Added workflow to publish to npm.

4426d19

Added workflow to publish to npm.

c98005f

Updated the eslint.js file

3be6c15

updated the workflow

0511207

Added build essentials

24da315

Updated the node vversion.

f5b472a

Updated the node version.

42cb649

u[dated the assetbrowser version.

f4499a6

u[dated the assetbrowser version.

6cef1d7

Update

e8370a7

Update

d0893f8

Update

99177a7

Updated the upload step

381b160

Updated the upload step.

40a25d6

Update readme and the workflow file.

bc47b6e

Updated Readme.

5f56c57

Updated cpy cmd.

c07d1fa

Reverted asstetbrowser version

f1142d8

Merge pull request #3 from vinodbhorge/git-action

7074fd6

Github action to build and push to blob

pallakartheekreddy requested a review from Copilot July 23, 2025 12:22

Copilot AI reviewed Jul 23, 2025

View reviewed changes

pallakartheekreddy previously approved these changes Jul 23, 2025

View reviewed changes

Update pull-request.yml

6fbcf5c

yashashkumar dismissed pallakartheekreddy’s stale review via 6fbcf5c July 31, 2025 13:16

Update plugin repository URL in publish workflow

4478c6e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coss 5.2.1 actions#88

Coss 5.2.1 actions#88
yashashkumar wants to merge 23 commits intoSunbird-Knowlg:release-5.2.1from
yashashkumar:coss-5.2.1-actions

yashashkumar commented Jul 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 23, 2025

Uh oh!

Copilot AI Jul 23, 2025

Uh oh!

Copilot AI Jul 23, 2025

Uh oh!

Copilot AI Jul 23, 2025

Uh oh!

Copilot AI Jul 23, 2025

Uh oh!

Copilot AI Jul 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	git clone --branch ${{ env.CONTENT_PLUGIN_VERSION }} https://github.com/vinodbhorge/sunbird-content-plugins.git plugins
	git clone --branch ${{ env.CONTENT_PLUGIN_VERSION }} https://github.com/Sunbird-Ed/sunbird-content-plugins.git plugins



	- name: Install dependencies
	run: npm install --legacy-peer-deps

-      - name: Clone content plugins
+      - name: Check if branch exists in sunbird-content-plugins
+        run: |
+          if git ls-remote --heads https://github.com/Sunbird-Knowlg/sunbird-content-plugins.git ${{ github.ref_name }} | grep -q ${{ github.ref_name }}; then
+            echo "Branch ${{ github.ref_name }} exists in sunbird-content-plugins."
+            echo "true" > branch_exists.txt
+          else
+            echo "Branch ${{ github.ref_name }} does not exist in sunbird-content-plugins."
+            echo "false" > branch_exists.txt
+          fi
+      - name: Clone content plugins
+        if: ${{ steps.check-branch.outputs.branch_exists == 'true' }}

	`CONTENT_PLUGIN_VERSION`: Have to specify the branch or tag you want fetch. By default it will take `release-8.0.0`
	`CONTENT_PLUGIN_VERSION`: Have to specify the branch or tag you want to fetch. By default it will take `release-8.0.0`

Conversation

yashashkumar commented Jul 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants