Skip to content

#SBCOSS-508: workflow for code quality check#127

Merged
HarishGangula merged 15 commits intoSunbird-Knowlg:release-8.0.0from
Rakshitha-D:workflows
Jun 3, 2025
Merged

#SBCOSS-508: workflow for code quality check#127
HarishGangula merged 15 commits intoSunbird-Knowlg:release-8.0.0from
Rakshitha-D:workflows

Conversation

@Rakshitha-D
Copy link
Copy Markdown
Collaborator

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Test A
  • Ran Test B

Test Configuration:

  • Software versions:
  • Hardware versions:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@HarishGangula HarishGangula requested a review from Copilot June 3, 2025 09:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds automated code quality checks via GitHub Actions, updates the README with a Code Quality section, and cleans up the legacy CircleCI configuration.

  • Introduce a new lint:fix npm script
  • Document linting, dependency management, formatting, and testing in README
  • Add a GitHub Actions workflow for linting and tests; remove CircleCI config

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Added lint:fix script for auto-fixing lint issues
README.md Introduced "Code Quality" section with commands overview
.github/workflows/pull_request.yml New workflow to run lint and tests on pull requests
.circleci/config.yml Removed legacy CircleCI configuration
Comments suppressed due to low confidence (2)

.circleci/config.yml:1

  • [nitpick] The .circleci/config.yml file was removed but the directory may still exist. If there are no other CircleCI configs in use, consider deleting the empty .circleci/ folder to prevent confusion.
-version: 2.1

README.md:400

  • [nitpick] The Table of Contents at the top of the README should be updated to include the new 'Code Quality' section for easier navigation.
## Code Quality

Comment thread .github/workflows/pull_request.yml
@HarishGangula HarishGangula changed the base branch from release-5.5.0 to release-8.0.0 June 3, 2025 11:52
@HarishGangula HarishGangula merged commit 3b26304 into Sunbird-Knowlg:release-8.0.0 Jun 3, 2025
1 of 2 checks passed
pallakartheekreddy added a commit that referenced this pull request Dec 30, 2025
* commit

* Issue #KN-686 feat: Updated readme file for integration setps for different frameworks(react, flutter, reactNative)

* Issue #KN-832 refactor: Updated the web component folders

* Issue #KN-832 feat: Add the package and updated circleci

* Issue #KN-862 docs: Updated the web component integration docs

* Issue #KN-862 docs: Updated the web component integration docs

* Issue #KN-862 docs: Updated the web component integration docs

* Issue #KN-862 feat: Updated the documentation and references

* pdf player changes to support languages (#126)

* #FP-I43: added multi language support pdf player static text in menus

* Fix #FP-I43: Handle language resource bundle for PDF player

* Fix #FP-I43: Handle language resource bundle for PDF player

* #SBCOSS-508: workflow for code quality check (#127)

* SBCOSS-508: workflow for code quality check

* SBCOSS-508: updated workflow

* SBCOSS-508: updated workflow

* SBCOSS-484: updated readme file

* SBCOSS-484: added script to fix lint issues

* SBCOSS-484: updated workflow

* SBCOSS-508: updated readme file

* SBCOSS-484: added script to fix lint issues

* SBCOSS-484: updated workflow

* SBCOSS-508: updated workflow

* SBCOSS-508: updated workflow

* SBCOSS-508: updated workflow

* SBCOSS-508: updated workflow

* SBCOSS-508: deleted circleci workflow

* SBCOSS-509: Added github actions for publishing to npm

* SBCOSS-509: Updated workflow file

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* SBCOSS-509: Updated Readme documentation for publishing to NPM

---------

Co-authored-by: Santosh <santosh.mattikoppa@ilimi.in>
Co-authored-by: harishkumar gangula <harish@sanketika.in>
Co-authored-by: Kartheek Palla <palla.kartheekreddy@gmail.com>
Co-authored-by: yashash <126703764+yashashkumar@users.noreply.github.com>
Co-authored-by: Deeksha Deepak <deekshad1502@gmail.com>
Co-authored-by: Deeksha Deepak <77612609+Deeksha1502@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants