#SBCOSS-508: workflow for code quality check#127
Merged
HarishGangula merged 15 commits intoSunbird-Knowlg:release-8.0.0from Jun 3, 2025
Merged
#SBCOSS-508: workflow for code quality check#127HarishGangula merged 15 commits intoSunbird-Knowlg:release-8.0.0from
HarishGangula merged 15 commits intoSunbird-Knowlg:release-8.0.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds automated code quality checks via GitHub Actions, updates the README with a Code Quality section, and cleans up the legacy CircleCI configuration.
- Introduce a new
lint:fixnpm script - Document linting, dependency management, formatting, and testing in README
- Add a GitHub Actions workflow for linting and tests; remove CircleCI config
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Added lint:fix script for auto-fixing lint issues |
| README.md | Introduced "Code Quality" section with commands overview |
| .github/workflows/pull_request.yml | New workflow to run lint and tests on pull requests |
| .circleci/config.yml | Removed legacy CircleCI configuration |
Comments suppressed due to low confidence (2)
.circleci/config.yml:1
- [nitpick] The
.circleci/config.ymlfile was removed but the directory may still exist. If there are no other CircleCI configs in use, consider deleting the empty.circleci/folder to prevent confusion.
-version: 2.1
README.md:400
- [nitpick] The Table of Contents at the top of the README should be updated to include the new 'Code Quality' section for easier navigation.
## Code Quality
3b26304
into
Sunbird-Knowlg:release-8.0.0
1 of 2 checks passed
pallakartheekreddy
added a commit
that referenced
this pull request
Dec 30, 2025
* commit * Issue #KN-686 feat: Updated readme file for integration setps for different frameworks(react, flutter, reactNative) * Issue #KN-832 refactor: Updated the web component folders * Issue #KN-832 feat: Add the package and updated circleci * Issue #KN-862 docs: Updated the web component integration docs * Issue #KN-862 docs: Updated the web component integration docs * Issue #KN-862 docs: Updated the web component integration docs * Issue #KN-862 feat: Updated the documentation and references * pdf player changes to support languages (#126) * #FP-I43: added multi language support pdf player static text in menus * Fix #FP-I43: Handle language resource bundle for PDF player * Fix #FP-I43: Handle language resource bundle for PDF player * #SBCOSS-508: workflow for code quality check (#127) * SBCOSS-508: workflow for code quality check * SBCOSS-508: updated workflow * SBCOSS-508: updated workflow * SBCOSS-484: updated readme file * SBCOSS-484: added script to fix lint issues * SBCOSS-484: updated workflow * SBCOSS-508: updated readme file * SBCOSS-484: added script to fix lint issues * SBCOSS-484: updated workflow * SBCOSS-508: updated workflow * SBCOSS-508: updated workflow * SBCOSS-508: updated workflow * SBCOSS-508: updated workflow * SBCOSS-508: deleted circleci workflow * SBCOSS-509: Added github actions for publishing to npm * SBCOSS-509: Updated workflow file Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * SBCOSS-509: Updated Readme documentation for publishing to NPM --------- Co-authored-by: Santosh <santosh.mattikoppa@ilimi.in> Co-authored-by: harishkumar gangula <harish@sanketika.in> Co-authored-by: Kartheek Palla <palla.kartheekreddy@gmail.com> Co-authored-by: yashash <126703764+yashashkumar@users.noreply.github.com> Co-authored-by: Deeksha Deepak <deekshad1502@gmail.com> Co-authored-by: Deeksha Deepak <77612609+Deeksha1502@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: