End event#135
Merged
HarishGangula merged 5 commits intoSunbird-Knowlg:developfrom Apr 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the PDF player emits an END telemetry event synchronously when the user exits content (to be more reliable during fast navigations like mobile hardware back), and bumps the web-component package version accordingly.
Changes:
- Add an explicit
viewerService.raiseEndEvent()call in the PDF player’sexitContent()handler. - Bump
@project-sunbird/sunbird-pdf-player-web-componentversion from2.0.0to2.0.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
projects/sunbird-pdf-player/src/lib/sunbird-pdf-player.component.ts |
Ensures an END event is emitted when the end-page “exit” action is triggered. |
web-component/package.json |
Publishes the change via a patch version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a. Synchronous END Event: exitContent and ngOnDestroy ogic in the PDF, ePub, and Video players to explicitly and synchronously call raiseEndEvent()
b. Previously, they depended on logic that could be safely executed in a browser but was too slow/fragile for a mobile "Hardware Back" navigation.