Skip to content

SBCOSS-510: workflow for code quality check#171

Merged
HarishGangula merged 4 commits intoSunbird-Knowlg:release-8.0.0from
Rakshitha-D:workflows
Jun 4, 2025
Merged

SBCOSS-510: workflow for code quality check#171
HarishGangula merged 4 commits intoSunbird-Knowlg:release-8.0.0from
Rakshitha-D:workflows

Conversation

@Rakshitha-D
Copy link
Copy Markdown
Collaborator

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Test A
  • Ran Test B

Test Configuration:

  • Software versions:
  • Hardware versions:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@HarishGangula HarishGangula requested a review from Copilot June 4, 2025 12:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a GitHub Actions workflow to perform code quality checks and removes the legacy CircleCI configuration.

  • Added a new GitHub Actions workflow (.github/workflows/pull_request.yml) to checkout code, set up Node.js, cache dependencies, install dependencies, run linting, and execute tests.
  • Removed the existing CircleCI CI configuration (.circleci/config.yml), likely to streamline CI/CD processes under GitHub Actions.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pull_request.yml New CI workflow for code quality checks using GitHub Actions
.circleci/config.yml Removed CircleCI configuration now that CI has migrated to GitHub Actions
Comments suppressed due to low confidence (1)

.circleci/config.yml:1

  • Since the CircleCI configuration has been removed in favor of GitHub Actions, please update the project documentation to reflect this change in the CI/CD pipeline.
Entire file deleted

Comment thread .github/workflows/pull_request.yml
@HarishGangula HarishGangula merged commit 2a67184 into Sunbird-Knowlg:release-8.0.0 Jun 4, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants