-
Notifications
You must be signed in to change notification settings - Fork 44
Upgrade From Play Framework 2.7.2 + Akka 2.5.22 to Play Framework 3.0.5 + Apache Pekko 1.0.3 #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sntiwari1
wants to merge
15
commits into
Sunbird-Lern:release-8.1.0
Choose a base branch
from
Sanketika-Bengaluru:release-8.0.0
base: release-8.1.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade From Play Framework 2.7.2 + Akka 2.5.22 to Play Framework 3.0.5 + Apache Pekko 1.0.3 #217
sntiwari1
wants to merge
15
commits into
Sunbird-Lern:release-8.1.0
from
Sanketika-Bengaluru:release-8.0.0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity report Co-authored-by: sntiwari1 <[email protected]>
Co-authored-by: sntiwari1 <[email protected]>
Co-authored-by: sntiwari1 <[email protected]>
Co-authored-by: sntiwari1 <[email protected]>
Co-authored-by: sntiwari1 <[email protected]>
- Removed storageConfig.toString() call causing scala.Serializable error - Fixed OnRequestHandler to use Http.Request instead of deprecated Context - Updated HealthController methods to accept Http.Request parameter - Fixed routes file to include request parameter for health endpoint - Fixed filters-helpers artifact name to play-filters-helpers - Build verified successful Co-authored-by: sntiwari1 <[email protected]>
…Serializable issues - Updated test imports from akka to pekko (ActorSystem, ActorRef, Props, TestKit) - Added scala-library dependency to all-actors for Scala type support - Fixed StorageConfig mocking in tests using PowerMockito method name stubbing to avoid scala.Serializable compilation errors - Build now succeeds with test compilation enabled Co-authored-by: sntiwari1 <[email protected]>
- Removed exclusion of jackson-module-scala_2.13 from service POM to allow proper Jackson module loading - Added exclusion of jackson-module-scala_2.11 from cert-processor's cloud-store-sdk dependency to prevent Scala version conflicts - Distribution now contains only jackson-module-scala_2.13-2.14.3.jar (Scala 2.13 compatible) - Fixes ServiceConfigurationError for DefaultScalaModule at runtime Co-authored-by: sntiwari1 <[email protected]>
- Updated all akka namespace references to pekko in application.conf - Changed akka.event.slf4j classes to org.apache.pekko.event.slf4j - Changed akka.actor classes to org.apache.pekko.actor - Changed akka.serialization to org.apache.pekko.serialization - Fixed akka.actor.allow-java-serialization to allow-java-serialization - Build verified successful with all Pekko configurations Co-authored-by: sntiwari1 <[email protected]>
- Created concise UPGRADE.md with essential upgrade information - Removed MIGRATION_COMPATIBILITY_REPORT.md (detailed technical analysis) - Removed MIGRATION_INDEX.md (navigation hub) - Removed MIGRATION_DECISION_TREE.md (visual decision guide) - Removed MIGRATION_SUMMARY.md (executive summary) - UPGRADE.md contains: overview, tech stack changes, key changes, build instructions, testing, known issues, and rollback plan - No icons, symbols, or file counts as requested Co-authored-by: sntiwari1 <[email protected]>
Removed verification steps and rollback plan from upgrade documentation.
… 1.0.3 Upgrade Play Framework to 3.0.5 and migrate from Akka to Apache Pekko 1.0.3
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the cert-service repository from Play Framework 2.7.2 + Akka 2.5.22 to Play Framework 3.0.5 + Apache Pekko 1.0.3.
The upgrade focuses on license compliance, improved security, and modernization to align with current Play and Pekko releases.
All functional and API compatibilities have been maintained while removing deprecated APIs and legacy configurations.
Motivation and Context
Type of Change
Technology Stack Changes
Key Changes
Dependencies
com.typesafe.play→org.playframework.Source Code
Migrated all Akka references to Pekko equivalents:
akka.actor→org.apache.pekko.actorakka.pattern→org.apache.pekko.patternakka.routing→org.apache.pekko.routingakka.util→org.apache.pekko.utilakka.testkit→org.apache.pekko.testkitplay.libs.akka→play.libs.pekkoscala.compat.java8.FutureConverters→scala.jdk.javaapi.FutureConvertersPlay 3.0 API Updates
PekkoGuiceSupportinstead ofAkkaGuiceSupportHttp.RequestparameterHttp.RequestparameterHttp.Requestparameter per Play 3.0 conventionsConfiguration
application.confreferences:akka→pekkoScala Version Handling
scala-library,scala-reflect, andjackson-module-scala_2.11)jackson-module-scala_2.13is included across all modulesBuild Instructions
Build all modules: