Skip to content

SST-202 allow ada increase in case of minutxo changes #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luivatra merged 1 commit into from
Jul 28, 2025
Merged

SST-202 allow ada increase in case of minutxo changes #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aiken.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ requirements = []
source = "github"

[etags]
"aiken-lang/fuzz@main" = [{ secs_since_epoch = 1753177596, nanos_since_epoch = 552264793 }, "9843473958e51725a9274b487d2d4aac0395ec1a2e30f090724fa737226bc127"]
"aiken-lang/fuzz@main" = [{ secs_since_epoch = 1753181341, nanos_since_epoch = 812689792 }, "9843473958e51725a9274b487d2d4aac0395ec1a2e30f090724fa737226bc127"]
94 changes: 57 additions & 37 deletions validators/pool.ak
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,14 +952,13 @@ validator manage(settings_policy_id: PolicyId) {
expect InlineDatum(datum) = pool_input.datum
expect datum: StablePoolDatum = datum
// We need the pool output to check that only the fees or fee manager are updated
let (
Output { address: pool_output_address, value: pool_output_value, .. },
pool_output_datum,
) = find_pool_output(outputs)
let (lovelace_diff, pool_output_datum) =
pool_output_datum(pool_input, outputs)

let StablePoolDatum {
lp_fee_basis_points,
protocol_fee_basis_points,
protocol_fees,
fee_manager: output_fee_manager,
..
} = pool_output_datum
Expand All @@ -970,15 +969,6 @@ validator manage(settings_policy_id: PolicyId) {
expect shared.fees_in_legal_range(protocol_fee_basis_points.1st)
expect shared.fees_in_legal_range(protocol_fee_basis_points.2nd)

let expected_datum =
StablePoolDatum {
..datum,
lp_fee_basis_points: lp_fee_basis_points,
protocol_fee_basis_points: protocol_fee_basis_points,
fee_manager: output_fee_manager,
}
expect pool_output_datum == expected_datum

// Check that the *current* fee manager approves the update
expect Some(fee_manager) = datum.fee_manager
expect
Expand All @@ -989,11 +979,19 @@ validator manage(settings_policy_id: PolicyId) {
withdrawals,
)

// And make sure we don't touch the assets on the pool input; they must be spent back into the same script
and {
pool_output_address == pool_input.address,
pool_output_value == pool_input.value,
}
let expected_datum =
StablePoolDatum {
..datum,
protocol_fees: (
protocol_fees.1st + lovelace_diff,
protocol_fees.2nd,
protocol_fees.3rd,
),
lp_fee_basis_points: lp_fee_basis_points,
protocol_fee_basis_points: protocol_fee_basis_points,
fee_manager: output_fee_manager,
}
pool_output_datum == expected_datum
}
AdjustLinearAmplification { pool_input } -> {
// Find the pool input; note that we don't look for the pool NFT here, because if someone
Expand All @@ -1005,12 +1003,11 @@ validator manage(settings_policy_id: PolicyId) {
let pool_input = pool_input.output
expect InlineDatum(datum) = pool_input.datum
expect datum: StablePoolDatum = datum
// We need the pool output to check that only the fees or fee manager are updated
let (
Output { address: pool_output_address, value: pool_output_value, .. },
pool_output_datum,
) = find_pool_output(outputs)

let (lovelace_diff, pool_output_datum) =
pool_output_datum(pool_input, outputs)

// We need the pool output to check that only the fees or fee manager are updated
let StablePoolDatum {
assets,
protocol_fees,
Expand All @@ -1033,15 +1030,6 @@ validator manage(settings_policy_id: PolicyId) {
sum_invariant,
)

let expected_datum =
StablePoolDatum {
..datum,
linear_amplification: linear_amplification,
sum_invariant: sum_invariant,
linear_amplification_manager: output_linear_amplification_manager,
}
expect pool_output_datum == expected_datum

// Check that the *current* fee manager approves the update
expect Some(linear_amplification_manager) =
datum.linear_amplification_manager
Expand All @@ -1056,12 +1044,44 @@ validator manage(settings_policy_id: PolicyId) {
// Make sure the linear amplification is valid
expect linear_amplification > 0

// And make sure we don't touch the assets on the pool input; they must be spent back into the same script
and {
pool_output_address == pool_input.address,
pool_output_value == pool_input.value,
}
let expected_datum =
StablePoolDatum {
..datum,
protocol_fees: (
protocol_fees.1st + lovelace_diff,
protocol_fees.2nd,
protocol_fees.3rd,
),
linear_amplification: linear_amplification,
sum_invariant: sum_invariant,
linear_amplification_manager: output_linear_amplification_manager,
}
pool_output_datum == expected_datum
}
}
// And make sure we don't touch the assets on the pool input; they must be spent back into the same script
}
}

fn pool_output_datum(
pool_input: Output,
outputs: List<Output>,
) -> (Int, StablePoolDatum) {
let (
Output { address: pool_output_address, value: pool_output_value, .. },
pool_output_datum,
) = find_pool_output(outputs)
expect pool_output_address == pool_input.address
expect
assets.without_lovelace(pool_output_value) == assets.without_lovelace(
pool_input.value,
)

// Allow for increased lovelace amount in case the minutxo cost of the output is larger than the input
// it is important to verify this is also added to the protocol fees so that the pool values are not changed
let lovelace_diff =
assets.lovelace_of(pool_output_value) - assets.lovelace_of(pool_input.value)
expect lovelace_diff >= 0

(lovelace_diff, pool_output_datum)
}