This repository was archived by the owner on Jul 29, 2023. It is now read-only.
Fix comments not loading after YouTube's custom navigation#206
Open
AjaxGb wants to merge 2 commits intoSuperManifolds:masterfrom
Open
Fix comments not loading after YouTube's custom navigation#206AjaxGb wants to merge 2 commits intoSuperManifolds:masterfrom
AjaxGb wants to merge 2 commits intoSuperManifolds:masterfrom
Conversation
YouTube fires several custom events while "loading" a page. The "spfdone" event indicates that the new page has finished loading. http://youtube.github.io/spfjs/documentation/events/
Author
|
I believe that this would resolve #194, which was created immediately after the internal loading system was released, but the bug report is not very clear. |
AjaxGb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For quite some time now, navigating to a new page using YouTube's internal loading system would prevent Reddit comments from showing up until the page was actually reloaded.
This fixes the issue by hooking into YouTube's custom page load event system. Specifically, it listens for the
"spfdone"event, which is equivalent to the native"DOMContentLoaded"event.http://youtube.github.io/spfjs/documentation/events/