🎨 refactor: Edited structure, code style, custom Allure reports#2
Open
SuperTapok wants to merge 3 commits into
Open
🎨 refactor: Edited structure, code style, custom Allure reports#2SuperTapok wants to merge 3 commits into
SuperTapok wants to merge 3 commits into
Conversation
SuperTapok
commented
Dec 22, 2023
SuperTapok
commented
Owner
- Edited project structure - added constants interface, fixed typos
- Added allure annotations for every test
* Edited project structure - added constants interface, fixed typos * Added allure annotations for every test
dalekskaro
reviewed
Dec 22, 2023
dalekskaro
left a comment
dalekskaro
left a comment
Collaborator
There was a problem hiding this comment.
Самое главное из ревью: дополнить Settings.java
| Arguments.of(16, "Romeo", new ArrayList<>(Arrays.asList("url1", "url2"))), | ||
| Arguments.of(17, "Julia", new ArrayList<>(Arrays.asList("url1", "url2"))), | ||
| Arguments.of(18, "Andrew", new ArrayList<>(Arrays.asList("url1", "url2"))) | ||
| Arguments.of(15, "Bullet", new ArrayList<>(Arrays.asList("url1", "url2"))), |
Collaborator
There was a problem hiding this comment.
Если совсем упарываться то все значения здесь надо вынести в отдельный интерфейс, но это если уж совсем не будет нечем занятсья
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.