Fix #3105 - Big rocks push small rocks through the floor #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed an optimization condition in collision_static function (collision_system.cpp) that skipped collision checks for smaller static objects. - Previously, when a big rock was processed, it would skip collision checks for a smaller rock beneath it, causing the smaller rock to fall through the floor. - Adjusting the condition to skip larger rocks instead would lead to the opposite issue—smaller rocks pushing larger ones through the floor. Closes SuperTux#3105
|
Should probably compare against #3231. |
|
@Hypernoot, you are right - this solution allows crushers to be pushed to the ground by small rocks In contrast, skipping the check_collisions step allows rocks to pass through the ground: Do you think this PR should resolve this bug and reopen #2038, or would you prefer that I address the other bug in this PR as well? |
|
@huntekye , I see that this bug is already being fixed in that PR in the same way I’m addressing it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function (collision_system.cpp) that skipped collision
checks for smaller static objects.
collision checks for a smaller rock beneath it, causing the
smaller rock to fall through the floor.
lead to the opposite issue-smaller rocks pushing larger ones
through the floor.
Closes #3105