Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In honor of Supertux week, I have decided to contribute something of a decent size. This Pull Request merges a lot of int and float duplicates in Supertux into single classes with templates and
using
. These classes include:Rect
andRectf
Size
andSizef
Vector
andVectori
(technically it was added, but still)The float variants of all of the classes were prioritized because they are more up-to-date than the int versions. This means
Rect
now has some asserts that weren't there before, and it has caught a couple of oversights in a few places... aaand thats why its still a draft PR. I need to finish fixing a bug in the tilemap code. I am releasing this as a draft so that things like codestyle can start being checked.