Skip to content

Fix bare except clauses in supervisor/xmlrpc.py #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koteshyelamati wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

Fix bare except clauses in supervisor/xmlrpc.py #1722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions supervisor/xmlrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def more(self):

return self.getresponse(body)

except:
except Exception:
tb = traceback.format_exc()
self.request.channel.server.logger.log(
"XML-RPC response callback error", tb
Expand Down Expand Up @@ -247,7 +247,7 @@ def multi(remaining_calls=remaining_calls,
except RPCError as exc:
value = {'faultCode': exc.code,
'faultString': exc.text}
except:
except Exception:
info = sys.exc_info()
errmsg = "%s:%s" % (info[0], info[1])
value = {'faultCode': Faults.FAILED,
Expand Down Expand Up @@ -276,7 +276,7 @@ def multi(remaining_calls=remaining_calls,
except RPCError as exc:
value = {'faultCode': exc.code,
'faultString': exc.text}
except:
except Exception:
info = sys.exc_info()
errmsg = "%s:%s" % (info[0], info[1])
value = {'faultCode': Faults.FAILED,
Expand Down Expand Up @@ -383,7 +383,7 @@ def continue_request(self, data, request):
if PY2:
data = data.encode('ascii', 'xmlcharrefreplace')
params, method = self.loads(data)
except:
except Exception:
logger.error(
'XML-RPC request data %r is invalid: unmarshallable' %
(data,)
Expand Down Expand Up @@ -433,7 +433,7 @@ def continue_request(self, data, request):
request.push(body)
request.done()

except:
except Exception:
tb = traceback.format_exc()
logger.critical(
"Handling XML-RPC request with data %r raised an unexpected "
Expand Down
Loading