input: add Vive Focus3 controller profile#298
Merged
Conversation
Supreeeme
reviewed
Feb 8, 2026
Comment on lines
+50
to
+69
| PathTranslation { | ||
| from: "x/touch", | ||
| to: "x/click", | ||
| stop: true, | ||
| }, | ||
| PathTranslation { | ||
| from: "y/touch", | ||
| to: "y/click", | ||
| stop: true, | ||
| }, | ||
| PathTranslation { | ||
| from: "a/touch", | ||
| to: "a/click", | ||
| stop: true, | ||
| }, | ||
| PathTranslation { | ||
| from: "b/touch", | ||
| to: "b/click", | ||
| stop: true, | ||
| }, |
Owner
There was a problem hiding this comment.
Is this right? This seems like it would be problematic if something that's supposed to be a touch binding is mapped as a click.
Contributor
Author
There was a problem hiding this comment.
The Focus 3 interaction profile doesn't have any touch inputs: https://registry.khronos.org/OpenXR/specs/1.1/html/xrspec.html#XR_HTC_vive_focus3_controller_interaction
which is weird, since I'm pretty sure on SteamVR it's supported..
ImSapphire
force-pushed
the
vive-focus3
branch
from
February 9, 2026 23:49
3d9c13f to
dcfad36
Compare
Owner
|
Looks like the test will need to enable the extension. Should be simple enough to add to fakexr. |
3 tasks
Contributor
Author
|
Oops, should be good now |
CheesecakeCG
pushed a commit
to CheesecakeCG/xrizer
that referenced
this pull request
Mar 21, 2026
* input/profiles/oculus_touch: remove duplicate path translation * input: add Vive Focus3 controller profile * input: only suggest profile bindings when profile is supported * fakexr: advertise XR_HTC_vive_focus3_controller_interaction extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.