Skip to content

input: add Touch Plus profile#308

Open
ImSapphire wants to merge 2 commits into
Supreeeme:mainfrom
ImSapphire:touch-plus
Open

input: add Touch Plus profile#308
ImSapphire wants to merge 2 commits into
Supreeeme:mainfrom
ImSapphire:touch-plus

Conversation

@ImSapphire

Copy link
Copy Markdown
Contributor

No description provided.

@Supreeeme

Copy link
Copy Markdown
Owner

I'm working on a refactor of how input profiles are implemented, so I'm going to wait to merge this until I'm done with that.

@Supreeeme

Copy link
Copy Markdown
Owner

Took longer than expected, but the refactor is now done.

@ImSapphire

Copy link
Copy Markdown
Contributor Author

Rebased

@Supreeeme

Copy link
Copy Markdown
Owner

Is there a fundamental reason for this profile to be added? It seems identical to the normal touch.

@skryvel

skryvel commented May 25, 2026

Copy link
Copy Markdown

I'd been working on something similar to reach a happy Quest 3 experience. I started going in this direction before noticing this PR here.

identical to the normal touch

Not sure if this is a relevant answer but, origin/main as of now does not work (completely at least) with Quest 3 controllers.

@ImSapphire

Copy link
Copy Markdown
Contributor Author

Is there a fundamental reason for this profile to be added? It seems identical to the normal touch.

It's mainly for the rendermodel. On main it uses the Quest 2 rendermodel.

@Supreeeme

Copy link
Copy Markdown
Owner

In that case, I would derive as much of the functions as possible from the existing Touch profile.

@ImSapphire

Copy link
Copy Markdown
Contributor Author

In that case, I would derive as much of the functions as possible from the existing Touch profile.

Do you mean like, replacing the body of e.g. legacy_bindings with OculusTouch::legacy_bindings(c)? I can't do that because of the generic type.

@Supreeeme

Copy link
Copy Markdown
Owner

You could create a trait, OculusLike or whatever - have the stuff that needs to be unique between the profiles as required trait functions, and add a blanket implementation for all types that implement OculusLike. There are quite a few touch-like controllers anyway like the Pico controllers, so that could end up pretty useful I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants