Skip to content

A few fixes for uploading new projects. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from Aug 20, 2018
Merged

A few fixes for uploading new projects. #16

merged 5 commits into from Aug 20, 2018

Conversation

tom-garratt-w
Copy link
Contributor

No description provided.

@Suremaker
Copy link
Owner

Hey Tom, I will look over the weekend to fix the pipeline for the project. Thanks for making improvements!

@tom-garratt-w
Copy link
Contributor Author

Hey, yeah you can see I'm having problems getting it to build on AppVeyor. We're doing similar stuff with dotnetcore in Jenkins Pipelines and we've wrangled OpenCover to do the dirty work, but a new PSMake dotnetcore module might be easier!

@pavlo-oliinyk
Copy link
Collaborator

Hey @tom-garratt-w
I tried to fix this also. Here are my changes to OPB. And it requires small changes in PSMake.
I could not run tests locally and have no idea where the problem is.
Have to find some time to fix it.

@Suremaker
Copy link
Owner

Hey guys, please take a look at #17 where I sorted out the make scripts.

I saw @pavlo-oliinyk fixes for the opencover but it's really a workaround as opencover still does not support portable pdbs. ... so instead of it, I changed the scripts to use dotcover.exe

If that will work for you, I'll merge the changes to 3.x branch... Also at some point I will merge it to master, making it default version

@williamlord williamlord merged commit ef6b133 into Suremaker:3.x Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants