Skip to content

Updated packing module to support NuGet.exe pack argument changes. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jpnewman
Copy link

After updating NuGet.exe to version 4.6.2 the 'output' argument for the pack command is not longer supported. This PR changes the deprecated 'Output' argument to 'OutputDirectory'.

Can you please create a new NuGet package on NuGet.org with this change?

@Suremaker
Copy link
Owner

Hello @jpnewman, sure I will update it, but there are still failing tests. Could you please fix them?

@JPNewman-Wonga
Copy link

Hi, I'll have a look at the failing tests and get them green. However, it seems that Nuget.exe version 4.6.2 changes the way it handles version numbers and mostly support SemVer 2.0.0.

Also it has versioning bugs like: -

This might mean that the TestSolutions and Tests with numbers like 1.0.0.0 might need to change to use SemVer, including psmake.mod.testing version 1.3.1.1.

@Suremaker
Copy link
Owner

Hey @JPNewman-Wonga , I think there is nothing wrong of adding a nuget.exe >= 4.6.2 requirement for the new version of psmake and update the versioning of it's packages, however we have to be sure that psmake will be able to properly resolve the dependencies via both: Modules.ps1 as well as Fetch-Package function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants