-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
Since it doesn't seem possible to trivially satisfy both stable and nightly branches, I see three options:
For 1 and 2 the |
A minor tweak to your 1 and 2 plan. Could we drop the nightly tests for the master branch, and do nightly tests against a develop branch? Stable tests against: Nightly tests against: This way develop can merge into directly into master as soon as the next version of Surreal is released with tests that are already green. The main downside is that it requires us to dev against a potentially buggy nightly. If there are release candidate builds of surreal, I could see this this strategy working very well. |
@Du-z That sounds great! Ill restructure according to your suggestion. Thanks for the input! |
I have reverted all code-changes in this branch, so that we can now merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just updated README.md to be a bit more explicit about which branch to merge the PR into.
Also i think the latest release didn't go out properly? Looks like it used the wrong version number.
..., preferable without breaking the stable branch