Chore/figma adaptations #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a trailing icon button for the event title field and the short description field to match with the figma design.
Zafouche
added
enhancement
Redd87
approved these changes
Dec 18, 2024
Collaborator
Redd87
left a comment
Redd87
left a comment
There was a problem hiding this comment.
Well done! the app is getting more polished everyday. I just had a comment about if we should hide the IconButton but it is debatable, so let me know what you think
app/src/main/java/com/android/unio/ui/authentication/AccountDetails.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@Redd87 Changes done. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to fix the small inconsistencies between the
Figmaand the actual implementation.Some fields or icons have been forgotten to be implemented, while for others, we had to take different paths so the changes had to be done in the
Figma(obviously not visible in this PR).Motivation and Context
The reason behind this PR is simply to improve consistency between our design and our implementation, and make sure we haven't forgotten to implement anything what was designed.
EventCreation
cleartrailing icon button to event title input field.cleartrailing icon button to event short description field.EventEdit:
cleartrailing icon button to event title input field.cleartrailing icon button to event short description field.EventEditComponents
AccountDetails
cleartrailing icon button to user first name input field.cleartrailing icon button to user last name input field.UserProfileEdition
cleartrailing icon button to user first name input field.cleartrailing icon button to user last name input field.How has this been tested?
What's left:
Other screens need to be checked with the
Figma, will be handled in different PRs (@Redd87 has already started a PR for other screens for instance).