Add highlighting to missing inputs in Event creation and Event edition #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romainhir
changed the title
Zafouche
requested changes
Dec 18, 2024
Collaborator
Zafouche
left a comment
Zafouche
left a comment
There was a problem hiding this comment.
I just player around with it, there seems to just be one missing.
For the EventEdition screen: It works well, no problems here.
For the EventCreation screen, the Description field is missing the red highlighting, so I'll request this simple change.
Other than that it looks good, nothing to say about the code. Good work
Collaborator
Author
|
Oh you are right, I forgot it, my bad |
Zafouche
approved these changes
Dec 18, 2024
Collaborator
Zafouche
left a comment
Zafouche
left a comment
There was a problem hiding this comment.
No problem.
Just pulled the change and tested it, it works. All done!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was flagged #269. It is part of polishing the inconsistencies of our app. In event creation/edition, you cannot save your work if some inputs are not filled out, but currently, it is not shown which input is missing. This task aims solve this issue