Removed trades sorting and trade types functions from App and moved it to sdk#1601
Open
Mi-Lan wants to merge 1 commit into
Open
Removed trades sorting and trade types functions from App and moved it to sdk#1601Mi-Lan wants to merge 1 commit into
Mi-Lan wants to merge 1 commit into
Conversation
✅ Deploy Preview for swapr ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
|
Tested and noticed difference was in the values of min. received between the results on the eco router results and the official dex website...
Sushiswap Uniswap |
Collaborator
Author
@MilanVojnovic95 Can you give steps to reproduce it...I can't trigger that behaviour for me it works. Thats very weird since its accurately inaccurate by 200$.... |
berteotti
approved these changes
Dec 2, 2022
berteotti
left a comment
berteotti
left a comment
Collaborator
There was a problem hiding this comment.
Awesome work man, looks good to me!
MilanVojnovic95
approved these changes
Jan 29, 2023
MilanVojnovic95
left a comment
MilanVojnovic95
left a comment
Collaborator
There was a problem hiding this comment.
Retested and the bug is no longer present. 👍
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
fb69230 to
0c5053c
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
ff47650 to
b3b3815
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
91e4f23 to
af06da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is linked to sdk pr SwaprHQ/swapr-sdk#221