[SWA-46] Limit order refactoring#1839
Draft
wixzi wants to merge 37 commits into
Draft
Conversation
✅ Deploy Preview for swapr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
berteotti
reviewed
Jun 16, 2023
berteotti
reviewed
Jun 16, 2023
berteotti
left a comment
berteotti
left a comment
Collaborator
There was a problem hiding this comment.
Code is looking good and organised. Just left a comment :)
wixzi
force-pushed
the
feature/limit-order-optimization
branch
from
b1dc737 to
cad6291
Compare
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
wixzi
force-pushed
the
feature/limit-order-optimization
branch
from
8767a3a to
0a08e7e
Compare
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
wixzi
force-pushed
the
feature/limit-order-optimization
branch
from
04912ba to
3557888
Compare
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
wixzi
force-pushed
the
feature/limit-order-optimization
branch
from
197882c to
4cacee5
Compare
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
added 8 commits
July 28, 2023 17:04
added 6 commits
July 28, 2023 17:04
wixzi
force-pushed
the
feature/limit-order-optimization
branch
from
55a45b7 to
22fb61c
Compare
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
wixzi
force-pushed
the
feature/limit-order-optimization
branch
from
7286c0e to
0345d92
Compare
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
github-actions
Bot
temporarily deployed
to
feature-limit-order-optimization
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
fb69230 to
0c5053c
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
ff47650 to
b3b3815
Compare
berteotti
force-pushed
the
develop
branch
2 times, most recently
from
91e4f23 to
af06da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: SWA-46
Description
Refactor limit order to accommodate new protocols and make it more maintainable code. This refactor aims to make the current CoW limit order work as it is in the new refactored code.
How to test the changes
CoW limit order should work without errors
Is there any risks or changes of failure to be considered
Medium: Limit order can cause issues.