CMRT 23: Fixup: CMRT Phase 1

[Swarnadip-Kar]

Consolidates all verified review issues from the CMRT 20–21 pass and two
isolated DAO bug fixes. All items are non-blocking — they improve correctness
and style without changing any user-visible behaviour.

Section A — Code review issues

acoustidworker.h / .cpp

• Rename LookupResult::trackId/releaseId/artistId → musicbrainzReleaseId/ArtistId/TrackId. trackId is the Mixxx
  DB integer PK name everywhere; the field stores a MusicBrainz UUID.

wtrackmenu.cpp

• Add direct #include "library/dao/trackfingerprintdao.h" (IWYU).
• Remove unused progressLabelText + Q_UNUSED in slotClearFingerprint;
  add TODO(XXX) comment explaining why no progress dialog is used.
• Add TODO(XXX) before post-progress fingerprint loop in slotClearAllMetadata.

dlgpreffingerprint.h / .cpp

• Forward-declare TrackCollectionManager in header; full include in .cpp.

Section B — DAO bug fixes

trackfingerprintdao.cpp

• getFingerprintStoragePath: simplify to single QStringLiteral expression;
  remove QString::append mutation and redundant trailing slash.
• saveChromaFile: call tempFile.remove() before returning false in the
  write-failure path; prevents partial .tmp files remaining on disk.

Depends on: cmrt-feature-mbqueue-enhance (#29)

[coveralls]

Coverage Report for CI Build 27530527727

Coverage decreased (-0.001%) to 30.452%

Details

• Coverage decreased (-0.001%) from the base build.
• Patch coverage: 13 uncovered changes across 2 files (2 of 15 lines covered, 13.33%).
• 1 coverage regression across 1 file.

Uncovered Changes

File	Changed	Covered	%
src/musicbrainz/acoustidworker.cpp	12	0	0.0%
src/library/dao/trackfingerprintdao.cpp	3	2	66.67%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
src/library/dao/trackfingerprintdao.cpp	1	0.93%

---

Coverage Stats

Relevant Lines:	116174
Covered Lines:	35377
Line Coverage:	30.45%
Coverage Strength:	59272.59 hits per line

---

💛 - Coveralls