CMRT 25: Analyzer: Add QualityScorer for canonical-track selection - #34
Open
Swarnadip-Kar wants to merge 1 commit into
Open
CMRT 25: Analyzer: Add QualityScorer for canonical-track selection#34Swarnadip-Kar wants to merge 1 commit into
Swarnadip-Kar wants to merge 1 commit into
Conversation
Coverage Report for CI Build 27872363108Coverage increased (+0.001%) to 30.438%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds QualityScorer, a static utility that scores a track's audio quality
for CMRT canonical-track selection (CMRT 27/28 use this to decide which
track in a group of duplicate masterings becomes the canonical reference).
Scoring (Quality_Scoring_Ayush_Proposal.txt)
Not implemented: the proposal's bit-depth bonus
Bit depth has nowhere to be queried from yet -- it only exists inside
track_analysis's audio_quality JSON blob, written by a fake-lossless
detector that hasn't been built. Adding that bonus now would mean parsing
JSON in this PR for a feature that doesn't exist. Left as a comment in
qualityscorer.cpp pointing at whichever PR adds that detector.
Notes for reviewers
are two different structs on purpose -- this one is QualityScorer's input
shape, the other is what TrackFingerprintDao can cheaply SELECT. CMRT 27
adapts between them.
track length) -- flagged in a comment, not fixed, since that's a tuning
question once this runs against a real library.
Depends on: cmrt-dao-mbid-lookup (#33)