CMRT 28: DAO: Quality-based canonical re-election on track deletion - #37
Open
Swarnadip-Kar wants to merge 1 commit into
Open
CMRT 28: DAO: Quality-based canonical re-election on track deletion#37Swarnadip-Kar wants to merge 1 commit into
Swarnadip-Kar wants to merge 1 commit into
Conversation
Coverage Report for CI Build 27872505024Coverage increased (+4.2%) to 34.491%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the TODO(XXX) left in clearFingerprintData()
"Update this logic to select next canonical track ... instead of just
promoting the first member found in the group."
Changes
When the canonical track of a group is deleted:
(is_canonical=1, cmrt_offset_seconds=0) + updateMemberOffset()
(offset_from_canonical=0) -- all three methods already exist from
CMRT 27, so this PR adds zero new DAO surface.
canonical's .chroma file via FingerprintMatcher::compare().
Notes for reviewers
not expected to matter since identical scores would need byte-identical
files, which the SHA-256 cache already catches elsewhere, but noted in
case that assumption doesn't hold for some library.
replaceCanonical() in CMRT 27, for the same reason (small group sizes
expected in practice).
ScopedTransaction -- no new transaction boundaries, every new early
return relies on the same rollback-on-destruct behavior the rest of the
function already does.
Depends on: cmrt-pipeline-grouping (#36)