fix: include target names in build/ and .fingerprint/ cleanup#317
Merged
Swatinem merged 1 commit intoSwatinem:masterfrom Mar 14, 2026
Merged
fix: include target names in build/ and .fingerprint/ cleanup#317Swatinem merged 1 commit intoSwatinem:masterfrom
Swatinem merged 1 commit intoSwatinem:masterfrom
Conversation
Swatinem
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #235
When a package's lib name differs from its package name (e.g.,
jsonpath_lib_polars_vendorwith lib namejsonpath_lib), the cleanup step was deleting thebuild/and.fingerprint/artifacts becausekeepPkgonly contained the package name.This caused cache misses and unnecessary rebuilds on subsequent CI runs.
Include target names (with hyphens replaced by underscores) in the
keepPkgset, matching the existing behavior for thedeps/directory.