feat(escrow_contract): implement platform fee configuration and admin… - #31
Merged
Tybravo merged 2 commits intoApr 24, 2026
Merged
Conversation
|
@OluRemiFour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Done, Close #31 |
Collaborator
|
@OluRemiFour please resolve conflicts |
Contributor
Author
Done, Close: #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #12
Platform Fee Implementation:
Added update_platform_fee entrypoint with admin authorization and fee validation (max 10% / 1000 bps).
Implemented runtime storage updates for the PlatformFeeBps instance setting.
Added event emission for FeeUpdated using the Soroban event system.
Test Suite Stabilization:
Developed a comprehensive test suite in contracts/escrow_contract/test.rs.
Verified success cases (authorized fee updates), unauthorized access rejection, and invalid input rejection.
Resolved issues with event verification by transitioning to tuple-based topic formatting and explicit Val component comparison.
Confirmed state consistency by asserting get_platform_fee() returns correct values after updates.
Code Refinement:
Cleaned up unused imports and addressed deprecation warnings (e.g., migrating to modern event assertion patterns).
Ensured adherence to Soroban SDK v22.0.1 patterns.
Verification Results
All 4 unit tests for the escrow contract are passing successfully:
test_init_and_get_status: PASSED
test_update_platform_fee_success: PASSED
test_update_platform_fee_unauthorized: PASSED
test_update_platform_fee_invalid_value: PASSED