feat(escrow_contract): implement two-step admin transfer mechanism - #32
Merged
Merged
Conversation
…st.rs feat(escrow_contract): implement two-step admin transfer mechanism
|
@Ogstevyn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
propose_adminso the current admin can nominate a new admin address (stored aspending_adminin instance storage)accept_adminso the nominated address can claim the admin role; atomically updatesadminand clearspending_adminon acceptanceinitnow stores the initializer as the firstadminget_adminview function needed to verify admin stateAdminTransferred { old_admin, new_admin }event on successful transferTest plan
test_init_and_get_status— existing test still passestest_propose_and_accept_admin— end-to-end two-step transfer succeedstest_accept_admin_rejected_for_non_pending— panics when wrong address callsaccept_admintest_admin_cleared_after_transfer— old admin no longer set, new admin confirmedtest_admin_transfer_emits_event— event published on transferCloses #14