implemented TTL and storage ledger extension for escrow - #33
Merged
Tybravo merged 1 commit intoApr 23, 2026
Merged
Conversation
|
@Ogstevyn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ESCROW_TTL_THRESHOLD(518,400 ledgers ≈ 30 days) andESCROW_TTL_EXTEND_TO(1,555,200 ledgers ≈ 90 days) in amod constantsblock with inline rationale commentspersistent()storage (correct type for escrow records under Stellar's state-rent model) with TTL extended on every writeadmin,pending_admin) has TTL extended on every admin action:init,propose_admin, andaccept_adminget_amountview function to support persistent storage verification in testsTest plan
test_init_and_get_status— existing test still passestest_propose_and_accept_admin— still passes with TTL calls addedtest_accept_admin_rejected_for_non_pending— still panics correctlytest_admin_cleared_after_transfer— still passestest_admin_transfer_emits_event— still passestest_init_persists_escrow_amount_with_ttl— amount is readable from persistent storage after inittest_propose_admin_extends_instance_ttl— propose_admin succeeds with TTL extension, state correcttest_accept_admin_extends_instance_ttl— accept_admin succeeds with TTL extension, admin updatedCloses #15