Feat/delivery contract initialization - #40
Merged
Tybravo merged 2 commits intoApr 25, 2026
Conversation
|
@BigJohn-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
Description
This PR implements the unified
initfunction for the Delivery Contract, establishing the essential cross-contract link to the Escrow contract upon instantiation. It refactors the previous fragmented approach by replacinginit_adminandset_escrow_contractwith a single, atomic initialization path.Summary of Work Done
init(env: Env, admin: Address, escrow_contract: Address)to store both administrative and escrow contract addresses dynamically inside instance storage.AlreadyInitializedpanic to guarantee the contract cannot be re-initialized.delivery_countervariable to0inside persistent storage.DeliveryContractInitializedevent payload securely on successful resolution.test.rsmock suite: Simplified legacy helper functions by registering theMockEscrowinstantly insidesetup_test.test_init_state_and_event) and double-invocation handling (test_double_init).Cross-Contract Dependencies Introduced
No new crate dependencies were introduced; however, the logic solidifies the architectural boundary that a Delivery Contract now inherently depends on a valid Escrow Address during the bootstrap phase rather than at runtime lazily.
Test
All unit tests have been strictly verified to pass locally matching the expected acceptance criteria.