Feat/get escrow state query - #41
Merged
Tybravo merged 2 commits intoApr 25, 2026
Merged
Conversation
|
@BigJohn-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Description
This PR implements the
get_escrowpublic read-only query function for the Escrow Contract, enabling both frontend and backend layers of the SwiftChain logistics platform to inspect the current state and structure of any escrow record robustly.Summary of Work Done
get_escrow_recordfunction with the standardized publicget_escrow(env: Env, delivery_id: u64)API.DeliveryNotFoundenum natively intoEscrowError.env.storage().persistent().has(..)accurately before fetching—if the delivery ID does not exist, the mechanism immediately bubbles up anEscrowError::DeliveryNotFoundtarget panic.Escrowstructure dependencies natively toDataKeymatching the target lookup specifications.escrow_contract/test.rsintegration suite to safely utilize the new structured query function everywhere over legacy methods.test_get_escrow_not_foundunit test confirming missing query states evaluate dynamically toward the intended exception behaviors.Cross-Contract Dependencies Introduced
No new cross-contract bounds were introduced. Operation purely expands persistent storage viewing capacities transparently for the SwiftChain Platform layers.
Test
All unit tests executed transparently across the Soroban SDK. No state mutations occur during reads.