add ssh support#37
Merged
Merged
Conversation
9155e95 to
be12e86
Compare
be12e86 to
6231650
Compare
88decf5 to
779fcca
Compare
779fcca to
47d832a
Compare
a7b6e8a to
703d49b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
coman execcommand that can serve as a docker entrypoint (similar to tini) and executes iroh-ssh in the background with a provided secret.Adds a new (hidden)
coman proxycommand that is a thin wrapper aroundiroh-ssh proxyfor proxying ssh connections.Significantly modifies
coman cscs job startcommand to:comanexecutablecomanwith the generated iroh secret<job_name>-<job_id>for the job in ~/.local/share/coman/ssh_config with a ProxyCommand set tocoman proxy <job_id>, which proxies the connection.a user can then simply connect with
ssh <job_name>-<job_id>.TODO (left as an exercise for the reader):
add some garbage collection to clean up old SSH connections for jobs that aren't running anymore--waitflag to wait for jobs to be up on start (so a user doesn't try to connect when the container isn't running yet)check if the coman squash is already present on CSCS and only upload if the one on github is newer than the one on cscs (or try to match local version of coman?)