fix: use CNB_TARGET_* environment variables#151
Merged
Conversation
leafty
commented
Dec 3, 2025
SalimKayal
reviewed
Dec 4, 2025
SalimKayal
previously approved these changes
Dec 4, 2025
SalimKayal
approved these changes
Dec 5, 2025
SalimKayal
pushed a commit
that referenced
this pull request
Jan 13, 2026
Closes #148. Removes os and arch detection in `build` scripts and instead use the `CNB_TARGET_OS` and the `CNB_TARGET_ARCH` environment variables. Also, print a warning if the detected architecture (from `uname`) is different from the target architecture: at the moment, cross-platform builds with pack will very likely create an image with incompatible binaries (as many buildpacks use `uname` and not target platform metadata).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148.
Removes os and arch detection in
buildscripts and instead use theCNB_TARGET_OSand theCNB_TARGET_ARCHenvironment variables.Also, print a warning if the detected architecture (from
uname) is different from the target architecture: at the moment, cross-platform builds with pack will very likely create an image with incompatible binaries (as many buildpacks useunameand not target platform metadata).