fix: pr actions#74
Closed
SalimKayal wants to merge 2 commits into
Closed
Conversation
Member
|
Thanks for working on this @SalimKayal! I think a better solution might be to not trigger these workflows on tags but instead make them manually triggered? For example, like we do here: https://github.com/SwissDataScienceCenter/renku/blob/master/.github/workflows/create-release-branch.yml#L3-L13 That way we don't need the force push and tag rewriting, which are a bit hacky maybe? |
Collaborator
Author
|
yep that's better indeed. do we need the target branch or should we simply use main's head? |
Member
|
oh probably don't need the target branch, it will always be main |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve CI/CD for release process
Description:
This PR introduces enhancements to our CI/CD pipeline, specifically focusing on the release process and branch protection.
Key changes include:
repository_dispatchevents, allowing tests to run automatically for release-related pull requests, which helps satisfy branch protection rules. This ensures that release branches are always thoroughly tested before merging.update-versionsworkflow to usegit push --force --tagswhen pushing release tags. This addresses the fact that the release process rewrites the tag for the new file versions.These changes aim to make our release process more robust and compliant with branch protection policies.