feat: modal for creating session launch links#3665
Merged
Conversation
ciyer
had a problem deploying
to
renku-ci-ui-3665
GitHub Actions
Failure
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3665.dev.renku.ch |
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
77161cc to
921f729
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
921f729 to
e1b7a3f
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
a29ec7a to
8fdaee4
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
2 times, most recently
from
1f50d82 to
63ce1ca
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
63ce1ca to
9bedf46
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
9bedf46 to
63b3c41
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
5289170 to
9d871fb
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
72ae434 to
e763c04
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
23ef57d to
6fa0b4a
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
eb2a09f to
aed3d5a
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
d27a760 to
67c71d5
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
67c71d5 to
f649c4d
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
f649c4d to
8efd120
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
8efd120 to
09e3e9d
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
09e3e9d to
e200cf4
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
e200cf4 to
6c1cb47
Compare
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
6c1cb47 to
7fa7845
Compare
andre-code
requested changes
May 12, 2025
Contributor
andre-code
left a comment
andre-code
left a comment
There was a problem hiding this comment.
The code looks good and works as expected. I did notice that the modal for sharing the link is not available on the session view page yet, even though it was recently included
last version:
In this PR:
ciyer
force-pushed
the
ciyer/session-start-link-modal
branch
from
7fa7845 to
b9724e2
Compare
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/deploy renku=release-0.68.0 renku-data-services=main