Apply usage quotas to user sessions#4083
Conversation
a3578e9 to
064eb99
Compare
064eb99 to
76e35b2
Compare
|
You can access the deployment of this PR at https://renku-ci-ui-4083.dev.renku.ch |
483efc0 to
efca541
Compare
48a3cbc to
27a68f9
Compare
dbb9c7e to
9bdc904
Compare
5e32174 to
5dd4e34
Compare
There was a problem hiding this comment.
Note: the UI uses "paused", so we should name it sessionsV2Paused.json
| <div className={cx("d-flex", "align-items-center", "gap-2")}> | ||
| <Stopwatch fontSize={16} className="flex-shrink-0" /> | ||
| <span> | ||
| <strong>{usageAvailableHours}h of compute time</strong> until quota is |
There was a problem hiding this comment.
Maybe this line should also use usageAvailableString().
| }) { | ||
| if (usageAvailableHours <= 0) | ||
| return ( | ||
| <div className={cx("d-flex", "align-items-center", "gap-2")}> |
There was a problem hiding this comment.
Why use a div with flex here? Does it not work to just return <> or a <span>?
return (<><Alarm fontSize={16} className={cx("bi", "me-2")} />Usage...</>);
|
|
||
| interface ActiveSessionButtonProps { | ||
| className?: string; | ||
| usageAvailable: SessionLauncherResourceUsageAvailable; |
There was a problem hiding this comment.
Why not pass the resourceClass here?
| usageAvailable: SessionLauncherResourceUsageAvailable; | |
| resourceClass: ResourceClassWithIdFiltered; |
| > | ||
| <div> | ||
| <ActiveSessionButton | ||
| usageAvailable={{ |
There was a problem hiding this comment.
See comment about using resourceClass in the prop: you would just pass resourceClass={userLauncherClass}.
There was a problem hiding this comment.
Comment about the API: I don't understand why the usage values are returned only for the GET /resource_pool endpoint. Would it not make sense to include that in all other resource pool and resource class endpoints?
* feat: present usage quota information at session launch time * feat: show usage availabilty information when viewing session launcher details * feat: show usage availability for running or paused sessions * feat: show usage availability during session start * feat: prevent resume if quota is used
4c1cf84 to
987bb52
Compare
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
* build: update computeResources api * feat: present usage quota information at session launch time * feat: show usage quota information when viewing session launcher details * feat: show usage quota for running or paused sessions * feat: show usage quota during session start * feat: prevent resume if usage quota is used
* build: update computeResources api * feat: present usage quota information at session launch time * feat: show usage quota information when viewing session launcher details * feat: show usage quota for running or paused sessions * feat: show usage quota during session start * feat: prevent resume if usage quota is used
* build: update computeResources api * feat: present usage quota information at session launch time * feat: show usage quota information when viewing session launcher details * feat: show usage quota for running or paused sessions * feat: show usage quota during session start * feat: prevent resume if usage quota is used
* build: update computeResources api * feat: present usage quota information at session launch time * feat: show usage quota information when viewing session launcher details * feat: show usage quota for running or paused sessions * feat: show usage quota during session start * feat: prevent resume if usage quota is used
* build: update computeResources api * feat: present usage quota information at session launch time * feat: show usage quota information when viewing session launcher details * feat: show usage quota for running or paused sessions * feat: show usage quota during session start * feat: prevent resume if usage quota is used
* build: update computeResources api * feat: present usage quota information at session launch time * feat: show usage quota information when viewing session launcher details * feat: show usage quota for running or paused sessions * feat: show usage quota during session start * feat: prevent resume if usage quota is used
* build: update computeResources api * feat: present usage quota information at session launch time * feat: show usage quota information when viewing session launcher details * feat: show usage quota for running or paused sessions * feat: show usage quota during session start * feat: prevent resume if usage quota is used
Use this again once the notifications have been merged into the feature branch
renku-data-services=build/resource-quotas
/deploy renku-data-services=build/resource-quotas-notification #extra-values=dataService.dataTasks.enableResourceRequestTracking=true